How do you review a policy rule you cannot follow well enough to confirm it matches the written standard?
answer
- approval is an attestation, not a taste check
- readability is a control property
- ask for a must-not-flag fixture
- a vacuous rule is always green
- unreadable becomes a paper control
basics
~20 sYou do not approve it. Approval attests that the rule says what the standard says, and you cannot attest to logic you cannot follow. Ask for named intermediate steps and a case the rule must not flag.
solid answer
~50 sI do not approve it. Reviewability is a property of the rule, not of the reviewer: my approval is an attestation that this rule says what the written standard says, and I cannot give that for logic I cannot follow. I ask for three things — the rule restated with named intermediate steps so each piece lines up with a clause of the standard, a fixture the rule must reject, and a fixture the rule must **not** flag, because a rule that matches nothing passes every allow-case silently. If it cannot be made readable in the style it is written in, that is evidence the requirement has outgrown that style rather than a comment on the author. Merging a correct rule nobody else can read leaves a control that exists on paper: it cannot be safely changed later, so it gets exempted instead of fixed.
go deeper
Know that approving a policy rule means claiming it matches the written standard, so not understanding it is a reason to ask questions rather than a reason to defer to the author.
Be able to ask for the concrete things that make a rule checkable: named steps mapped to clauses, a case that must be rejected, and a case that must not be flagged.
Demonstrate that you hold the line on an opaque rule and can explain the cost in operational terms — no attestation, no safe change, exceptions instead of fixes — without making it about the author.
Own the norm: decide what your organisation's review of a guardrail must produce as evidence, and accept that a clause with no reviewable rule is better handled openly than by a control that exists only on paper.
## What you are actually signing When you approve a policy rule you are not saying *this looks like working code*. You are attesting that the executable rule and the written standard say the same thing. That attestation is the only link between the paragraph an auditor reads and the check that runs on every change. If you cannot follow the rule, you cannot make that link, and approving anyway breaks the chain quietly — everything stays green, and nobody finds out until the rule is tested by a real incident or a real audit. So the first move is to say the boundary out loud, without making it about the author: *I can see this passes its tests; I cannot confirm it enforces clause 4.2, so I cannot approve it in this form.* ## Reviewability is a property of the rule The unproductive version of this conversation treats readability as taste — my preferences against yours. It is not. A guardrail is a control, and a control that only one person understands has a single point of failure who will eventually change teams. Concretely, an unreviewable rule costs you: - **Attestation.** No second person can confirm what it enforces, now or a year from now. - **Change.** Nobody dares modify it, so when it misfires the team routes around it with an exception instead of fixing it. - **Drift.** When the standard is revised, nobody can tell which part of the rule corresponds to the revised clause. That is the outcome to name in the review: not *this is ugly*, but *this becomes a control on paper*. ## The three things to ask for **1. Named intermediate steps.** Ask the author to decompose the rule so each named piece corresponds to one clause of the standard. A rule expressed as *the multi-replica workloads*, *the budgets covering a label set*, and *a workload with no covering budget* can be reviewed line by line against the paragraph. The same logic as one nested expression can only be reviewed by holding it all in your head at once. **2. A case the rule must reject.** Obvious, and usually present. **3. A case the rule must *not* flag.** This is the one that gets skipped, and it is the one that catches the most dangerous defect: a rule that is silently vacuous. A rule whose condition never matches anything reports zero violations for every input. It passes the whole existing repository, it produces a clean report every quarter, and it enforces nothing. The allow-case fixture is what proves the rule is looking at something. ## When passing tests are offered as the answer Authors often respond that the test suite is green. Tests show the rule agrees with the fixtures someone wrote — usually the same person who wrote the rule, thinking about the same cases. Review asks a different question: does the rule say what the *standard* says, including for inputs nobody thought of. Both are needed, and neither substitutes for the other. ## When the rule cannot be made readable Sometimes the author is right that no clearer version exists in the style they are using. Take that as information about the language, not about them. If the requirement needs quantification across objects and a join, and the house style offers only single-object shape matching or a single expression, then the readable version lives in a style that can name intermediate results. Three outcomes are legitimate: - move this one rule to the style that fits, if the platform keeps such an escape hatch; - ship a deliberately narrower rule and record in the standard exactly what it does and does not check; - do not ship a rule at all for this clause, and handle it by review or detection instead, honestly recorded as such. All three are better than the fourth option, which is merging something correct and opaque and calling the control implemented. ## How to write the review comment Keep it about the artifact and the standard. Quote the clause, point at the part of the rule you cannot map to it, and say what would let you approve: a decomposition, the two fixtures, or a note in the standard describing the narrower scope. Offer a pairing session rather than rewriting it yourself — the author keeps ownership, and the rule that comes back is one that two people can read. ## What good looks like afterwards A rule you can hand to somebody who has never seen the policy repository, next to the paragraph it enforces, and they can tell you within a minute whether the two agree. That is the bar. Every property people actually want from policy as code — audit evidence, safe change, shared authorship — is downstream of it.
- The author points at a green test suite. Is that enough to approve?No. Tests show the rule agrees with fixtures the author chose; review asks whether the rule says what the standard says. A rule can pass every fixture and still be vacuous — matching nothing at all, and so reporting zero violations forever. What convinces a reviewer is a rule they can read plus a case the rule must not flag.
- What if the rule genuinely cannot be made readable in the style it is written in?Treat that as evidence about the language, not the author. If the requirement needs quantification and a join while the style offers only single-object shape matching, the readable version lives in a style with named intermediate steps. Say so in the review, then either move that one rule or ship a narrower rule whose reduced scope is written into the standard.
- Is it fair to block a rule that is provably correct?Yes, and it is worth framing why. Correctness today is not the property the organisation is buying; the ability of a second person to confirm what it enforces next quarter is. An opaque rule cannot be attested to, cannot be safely edited when it misfires, and cannot be remapped when the standard changes — so it accumulates exceptions instead of maintenance.
saying these in an interview costs you the question
- Approves it because it is correct and the pipeline is green
- Treats readability as personal taste rather than a control property
- Assumes passing tests prove the rule matches the standard
- Never asks for a case the rule must not flag
- Silently rewrites the rule instead of naming the problem